Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show terms of service & privacy policy notices #1390

Closed
BenHenning opened this issue Jun 23, 2020 · 1 comment · Fixed by #3852
Closed

Show terms of service & privacy policy notices #1390

BenHenning opened this issue Jun 23, 2020 · 1 comment · Fixed by #3852
Assignees
@veena14cs
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.9 Release Block...

Comments

@BenHenning
Copy link
Member

We should show links to the Oppia terms of service & privacy policy in each of the following circumstances:

  • When a user logs into an account
  • When a user creates a new profile & logs in for the first time (this is targeting the user who is using the profile)
  • When a user opens the navigation drawer

In places where a user is signing in, we should make it clear that they are agreeing to the TOS & privacy policy when signing into their account & using the app.
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Jun 23, 2020
@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@veena14cs veena14cs mentioned this issue Sep 28, 2021
Merged
6 tasks
@veena14cs veena14cs self-assigned this Jan 18, 2022
@BenHenning BenHenning modified the milestones: Beta, Beta MR1 Jun 11, 2022
@Broppia Broppia added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). issue_type_infrastructure labels Jul 29, 2022
BenHenning added a commit that referenced this issue Aug 26, 2022
@veena14cs @BenHenning
Fix #1390: Show terms of service & privacy policy notices. (#3852)
1ca0a4a 
* fix  color and null checks

* added number formatter for numbered list

* Update LiTagHandler.kt

* Update CustomHtmlContentHandler.kt

* Update CustomHtmlContentHandler.kt

* added files to build.bazel

* Update test_file_exemptions.textproto

* fixed ci errors

* fix lints

* Add local for number formatter

* Update LiTagHandler.kt

* fix lint checks

* fix policy-type declaration failure

* Added number formatter

* Update MachineLocaleImpl.kt

* Update BUILD.bazel

* Trigger Build

* fix html build

* Update BUILD.bazel

* Update app/src/main/res/values/strings.xml

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* Update utility/src/main/java/org/oppia/android/util/parser/html/PolicyType.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* Update utility/src/main/java/org/oppia/android/util/parser/html/PolicyType.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* fixed nits

* fixed html parser

* fixed bulletspan

* fixed lint

* fixed conflicts

* Update HtmlParserTest.kt

* fixed lint

* Update HtmlParser.kt

* Fixed ci failure for customContentHandler

* fixed lints

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* Fixed taghandler error

* fixed listener dependencies

* Update ListItemLeadingMarginSpan.kt

* Update BUILD.bazel

* Fixed failing tests in utility

* fixed lint

* fix tests

* Update utility/src/main/java/org/oppia/android/util/parser/html/HtmlParser.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* Update arguments.proto

* fix number formatting

* Fixed bullet gap and failing tests

* Update MachineLocaleImplTest.kt

* fixed errors

* Update HtmlParserTest.kt

* Update HtmlParserTest.kt

* Add 2 create methods with and without loading image

* Update HtmlParserTest.kt

* add displaylocale to utility

* Update HtmlParserTest.kt

* fixed nits

* fix lint

* Update HtmlParserTest.kt

* Update LiTagHandler.kt

* Update MachineLocaleImpl.kt

* Update HtmlParserTest.kt

* added tests in bazel

* fixed locale in tests

* Update BUILD.bazel

* removed test from bazel

* fix bazel format

* Update AppLanguageResourceHandler.kt

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* Update CODEOWNERS

* Delete BulletTagHandler.kt

* Update app/src/main/res/values/strings.xml

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* Update app/src/main/java/org/oppia/android/app/translation/AppLanguageResourceHandler.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* moved strings file to utility

* fixed changes

* removed unused import

* Update MachineLocaleImplTest.kt

* fixed testcases

* Update PoliciesFragmentTest.kt

* Update file_content_validation_checks.textproto

* Update file_content_validation_checks.textproto

* Update BUILD.bazel

* fixed file validations errors

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* removed test resources from domain

* Update BUILD.bazel

* Update DisplayLocaleImplTest.kt

* Update utility/src/main/java/org/oppia/android/util/parser/html/CustomHtmlContentHandler.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* Update utility/src/main/java/org/oppia/android/util/parser/html/LiTagHandler.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* Update utility/src/main/java/org/oppia/android/util/parser/html/ListItemLeadingMarginSpan.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* Update utility/src/main/java/org/oppia/android/util/parser/html/LiTagHandler.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* optimized code

* fixed errors in tests

* fixed tests

* fixed testcases

* fixed nit

* fixed nits

* Update CustomHtmlContentHandlerTest.kt

* Update Project.xml

* Update BUILD.bazel

* fixed testcases

* Update ListItemLeadingMarginSpan.kt

* Fixed create html parser create method

* fixed indentation

* Update ListItemLeadingMarginSpan.kt

* Update ListItemLeadingMarginSpanTest.kt

* Update LiTagHandlerTest.kt

* fixed issues

* removed list from custom tag handler

* fixed strings file

* Update CustomHtmlContentHandlerTest.kt

* fixed tests

* fixed lints

* Update DisplayLocaleImplTest.kt

* fixed gradle for test class

* fixed dependencies

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* removed exception

* Update BUILD.bazel

* Working on tests.

* Update BUILD.bazel

* fixed tests

* remove unused code

* fixed Litaghandler tests

* Update LiTagHandler.kt

* Update ListItemLeadingMarginSpanTest.kt

* fixing build file

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* Update BUILD.bazel

* fixing build file

* Update BUILD.bazel

* Update BUILD.bazel

* fix test resource path

* add test dependencies

* fix lint error

* Update DisplayLocaleImplTest.kt

* Update DisplayLocaleImplTest.kt

* commented unused code

* Update DisplayLocaleImplTest.kt

* Update BUILD.bazel

* Add utility dependency to test bazel

* Update DisplayLocaleImplTest.kt

* added locale in custom package

* fixing tests

* Update DisplayLocaleImplTest.kt

* Update DisplayLocaleImplTest.kt

* changed import to locale

* Remove R import

* Update app/src/sharedTest/java/org/oppia/android/app/parser/ListItemLeadingMarginSpanTest.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* fix bazel and span class

* Update app/src/sharedTest/java/org/oppia/android/app/parser/ListItemLeadingMarginSpanTest.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* fixed issues related to tests

* Update ListItemLeadingMarginSpanTest.kt

* Update ListItemLeadingMarginSpanTest.kt

* Update ListItemLeadingMarginSpanTest.kt

* compute x for RTL

* fixed nit

* Update LiTagHandler.kt

* Update LiTagHandler.kt

* Fixed lint errors

* Update LiTagHandler.kt

* Update ListItemLeadingMarginSpan.kt

* fixed extention method and tos and faq strings

* Update DisplayLocaleImpl.kt

* fixed rtl in html parser

* fixed lint errors

* Update PoliciesFragmentTest.kt

* fixed tests for rtl

* Update HtmlParserTest.kt

* Update HtmlParser.kt

* Update LiTagHandler.kt

* Update LiTagHandler.kt

* Update LiTagHandler.kt

* Update utility/src/main/java/org/oppia/android/util/locale/OppiaLocale.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>

* fixed nit

* Update LiTagHandler.kt

* Fixed canvas width in test

* Update ListItemLeadingMarginSpanTest.kt

* Update ListItemLeadingMarginSpanTest.kt

* Update ListItemLeadingMarginSpanTest.kt

* Update ListItemLeadingMarginSpanTest.kt

* Update ListItemLeadingMarginSpanTest.kt

Co-authored-by: Ben Henning <henning.benmax@gmail.com>
@KolliAnitha
Copy link

Terms of service and Privacy policy is seen on logging in for the first time, Navigation bar
Screenshot_2022-09-10-11-08-42-43_943a62cb4c6fb83e010e1c2e82766a17
Screenshot_2022-09-10-11-05-01-83_943a62cb4c6fb83e010e1c2e82766a17

@BenHenning BenHenning mentioned this issue Sep 15, 2022
Open
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Technical Roadmap - Android
Status: In Implementation
Milestone
0.9 Release Blockers (Beta "Early Acc...
Development

Successfully merging a pull request may close this issue.

Fix #1390: Show terms of service & privacy policy notices. veena14cs/oppia-android
4 participants
@BenHenning @veena14cs @KolliAnitha @Broppia