Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Drag and Drop Interaction #1483

Closed
rt4914 opened this issue Jul 17, 2020 · 2 comments · Fixed by #1498
Closed

Bug in Drag and Drop Interaction #1483

rt4914 opened this issue Jul 17, 2020 · 2 comments · Fixed by #1498
Assignees
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 17, 2020

Describe the bug
In Drag and Drop Exploration, if I pin all options and click on submit nothing happens and submit button becomes inactive.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'ExplorationRetriever'
  2. Map drag_and_drop_test_exploration.json (or) test_exp_id_4 such that it can be opened from any story.
  3. Now, pin all options such that it look similar to the screenshot
  4. Click submit
  5. See error - > Submit button will become inactive.

Expected behavior
Either there should be proper error message or some something to make sure that it does not look incomplete.

Screenshots
Screenshot_1595004646

@aggarwalpulkit596
Copy link
Contributor

aggarwalpulkit596 commented Jul 21, 2020

@BenHenning if you remember there was a change in the name of one classifier rule

and on the web we are still using the old name as per this json file
"rule_type": "IsEqualToOrderingWithOneItemAtIncorrectPosition",

@BenHenning BenHenning added this to the GSoC 2020 4.3: Milestone 2 milestone Jul 21, 2020
@BenHenning
Copy link
Member

We should ensure web & Android are consistent here, and that all of Android's local files are correct.

aggarwalpulkit596 added a commit that referenced this issue Jul 24, 2020
* rename rule to match web

* fix lint issues

* fix lint issues
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Development

Successfully merging a pull request may close this issue.

3 participants