Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11Y] Unable to exit overflow menu #3894

Closed
rt4914 opened this issue Oct 6, 2021 · 1 comment · Fixed by #4482
Closed

[A11Y] Unable to exit overflow menu #3894

rt4914 opened this issue Oct 6, 2021 · 1 comment · Fixed by #4482
Assignees
@vrajdesai78
Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Oct 6, 2021 •
edited
Loading

When a11y user is inside the overflow menu than currently there is no easy way to exit it. This might be a problem with the screen-reader (Talkback) itself as I have tested this on other apps like Whatsapp, Instagram and the experience is equally bad.

stuck_on_overflow.mp4
@rt4914 rt4914 added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Oct 6, 2021
@rt4914 rt4914 added this to the Beta milestone Oct 6, 2021
@rt4914
Copy link
Contributor Author

rt4914 commented Oct 6, 2021

We might need to use BottomSheet instead of Overflow Menu. Need to discuss with design team.

@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@vrajdesai78 vrajdesai78 self-assigned this Jul 23, 2022
@vrajdesai78 vrajdesai78 mentioned this issue Aug 1, 2022
Merged
6 tasks
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. and removed Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
BenHenning pushed a commit that referenced this issue Oct 1, 2022
@vrajdesai78
Fixes #3894: Unable to exit overflow menu (exploration + revision car…
87f0e98 
…d) (#4482)

* bottomsheet added

* Added test cases and optimized code

* Nit changes

* updated id

* klint issue fixed

* Fixed failing static check

* Bazel syntax fixed

* InjectableBottomSheetDialogFragment added and done nit changes

* Fixed failing CI checks

* nit changes

* Nit changes

* InjectableBottomSheetFragment added in Bazel

* material dependency added in bazel

* Rerun ci-checks

* BottomSheet added for RevisionCard

* Imports optimized

* Fixed nit changes in xml files

* Rerun ci checks

* RTL support added for close

* Revert "RTL support added for close"

This reverts commit 49c295c.

* showNow updated

* nit changes

* failing tests fixed

* Test added for BottomSheetOptionsMenu

* Optimized Code

* nit changes

* Made suggested changes

* optimized code

* Fixed static checks

* Fixed failing checks

* Created new BottomSheetOptionsMenuTest

* Fixed ktlint issues

* Fixed checks in bazel

* Optimized code

* Added dagger_rules() in bazel

* Nit changes in BUILD.bazel

* Updated Bazel

* androidx core deps added

* dependency added in bazel

* depdencies updated in bazel

* androidx dependencies added

* TestRunner dependency added

* databinding deps added in bazel

* annotation deps added

* annotation dep added to bazel

* All androidx test deps added

* commit to re-run checks

* Kdoc updated

* Remove practicetab

* Fixed menu icon

* Removed extra spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrajdesai78 vrajdesai78

Labels
Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
[Task Force] Full accessibility support - Android
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3894: Unable to exit overflow menu (exploration + revision card) vrajdesai78/oppia-android
5 participants
@rt4914 @BenHenning @vrajdesai78 @bkaur-bkj @Broppia