Project introduction #4
Assignees
Labels
Priority: Essential
This work item must be completed for its milestone.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Milestone
Comments
BenHenning
added
the
Priority: Essential
This was referenced Aug 2, 2019
Closed
Closed
Closed
Closed
2 tasks
This was referenced Aug 22, 2019
BenHenning
added a commit
that referenced
this issue
Aug 23, 2019
* Migrate ListenableFuture to a Kotlin coroutine, and split HomeActivity into both an activity and a fragment. * Introduce the domain and testsupport modules. The domain module includes a user app history controller that provides instances of a new AsyncResult interface that's meant to be a potential bridge between Kotlin coroutines and LiveData. The exact design of how this should work needs to be determined as part of #6. This also includes a new testsupport module that's required due to robolectric/robolectric#4736. This is supporting a new test for the app history controller that leverages an AndroidX activity scenario to test the live data. Note that the test does not yet work since there's a race condition between the LiveData's coroutines completing and the test continuing to verify the state of the activity. This needs to be resolved, likely by waiting for test visual elements to change based on the LiveData result. Additional tests need to be added for other new components, and some slight cleaning up may be necessary. * Fix binary build: testsupport should only be depended on for tests, not for production configurations. * Further attempts to try and test the asynchronous behavior of the new LiveData + kotlin coroutine system. This introduces a custom LiveData to mediate between Kotlin coroutines in a way that allows tests to actually ensure the coroutines resolve quickly, and ensure lifecycle safety through standard LiveData mechanisms. However, this doesn't actually fix the underlying tests (which have been changed in a number of ways in this commit in an effort to try and get them to pass). The kotlinx coroutine deps were downgraded to work around a NoSuchMethodError (see Kotlin/kotlinx.coroutines#1331). After introducing a runBlockingTest structure and updating the user app histoyr controller to use the test context, the operations seem to work correctly. However, one job is hanging which is causing the test to still fail (it appears to be deadlocked--no known amount of time allows it to resolve). This new NotifiableAsyncLiveData also appears to break the production behavior, as well. The LiveData result is no longer being observed by the data binding transformation function, so it seems the coroutines aren't being executed, aren't completing, or something is deadlocking somewhere. Further investigation is needed. * Fix the app not properly binding to the live data by ensuring the data binder had the view model set properly. Fix resource binding issues in Robolectric tests by ensuring binary resources are provided to Robolectric. Fix the controller tests not working by introducing a temporary, custom CoroutineLiveData that ensures no long-living jobs continue running after the live data is completed. * Clean up tests (we no longer need a testsupport module for this module introduction). * Add test for AsyncResult. Set code style for Groovy files & clean up all build gradle files. Add missing newlines at end of various files. * Reformat top-level build.gradle file, as well. * Address review comments: replace name-based TODOs with issues. * Address review comments: add EOF new lines.
8 tasks
JishnuGoyal
referenced
this issue
in JishnuGoyal/oppia-android
Sep 8, 2022
…alised-names Profiles cant have internationalised names
BenHenning
moved this to Needs Triage
in [Team] Developer Workflow & Infrastructure - Android
BenHenning
added
the
Z-ibt
BenHenning
modified the milestones:
Proof of concept,
0.1 Release Blockers (Prototype MR1) -- Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The initial Android Studio project structure should be introduced with each of the 5 modules described in the technical design document, with some interactions between them. These modules comprise of:
The text was updated successfully, but these errors were encountered: