Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topic should have navigation drawer icon in it #654

Closed
rt4914 opened this issue Feb 13, 2020 · 6 comments · Fixed by #741
Closed

Topic should have navigation drawer icon in it #654

rt4914 opened this issue Feb 13, 2020 · 6 comments · Fixed by #741
Assignees
@PrarabdhGarg
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 13, 2020

Mock: https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/c718fc6d-b336-475a-b31b-fd3bc84882a8/PM-EN-Play-Tab-Progress-1-

In mocks, the topic has a hamburger icon at top left corner of the screen which opens the navigation drawer.
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Workstream: Lowfi UI labels Feb 13, 2020
@PrarabdhGarg
Copy link
Contributor

@rt4914 for including the navigation drawer in the topic fragment, should I move the toolbar from within the fragment to the activity?
It would be easier to navigate that way.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 19, 2020 •
edited
Loading

@rt4914 for including the navigation drawer in the topic fragment, should I move the toolbar from within the fragment to the activity?
It would be easier to navigate that way.

@PrarabdhGarg Yes that i fine. At the same time I think the implementation that you are suggesting is similar to what is done in HomeFragment.

@PrarabdhGarg PrarabdhGarg mentioned this issue Feb 21, 2020
Closed
@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Feb 21, 2020 •
edited
Loading

@PrarabdhGarg @rt4914 Can I work on this issue? I had a duplicate issue(#680 ) and have generated a PR(#681) for it as well.
Also, we can implement navigation without moving the toolbar out of the fragment.

@PrarabdhGarg
Copy link
Contributor

@Sarthak2601 I am currently working on this

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 21, 2020

@PrarabdhGarg @rt4914 Can I work on this issue? I had a duplicate issue(#680 ) and have generated a PR(#681) for it as well.
Also, we can implement navigation without moving the toolbar out of the fragment.

@Sarthak2601 This issue has already been assign to @PrarabdhGarg and he is working on it.

At the same time the navigation icon in topics has been kept intentionally, so we tend not to remove it.

Also, I think you are assigned to oppia-web project but if you are interested in Oppia-Android. Feel free to inform us in gitter-group

Also, we will assigning you issues in start to keep everything organised.

@Sarthak2601
Copy link
Contributor

@rt4914 Okay, got it.
I am interested in Oppia-Android. I'll inform the same in the gitter group.
Thanks !

@PrarabdhGarg PrarabdhGarg mentioned this issue Mar 5, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Mar 19, 2020
@PrarabdhGarg
Fixs #654: Add Navigation Drawer Icon Topic (#741)
f1bd53b 
* Move toolbar from fragment to activity

* Add listener to get title from fragments in activity

* Add EOF at TopicTitleListener

* Fix some test cases

* Remove listener for toolbar title

* Add Tabs to topic fragment

* Nit changes

* Create new file for topic activity tests

* Add tests for topic activity tests

* Update tests for topic activity tests

* Minor Changes
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrarabdhGarg PrarabdhGarg

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fixs #654: Add Navigation Drawer Icon Topic PrarabdhGarg/oppia-android
4 participants
@rt4914 @BenHenning @PrarabdhGarg @Sarthak2601