Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thumbnails in Subtopic Domain layer to show in Revision tab. #703

Closed
veena14cs opened this issue Feb 24, 2020 · 4 comments
Closed

Add thumbnails in Subtopic Domain layer to show in Revision tab. #703

veena14cs opened this issue Feb 24, 2020 · 4 comments
Assignees
@veena14cs
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@veena14cs
Copy link
Contributor

veena14cs commented Feb 24, 2020 •
edited
Loading

Explanation

Add dummy thumbnails in subtopic list of Topic Json data. Update TopicController in domain layer to fetch thumbnails and display it in Topic Revision Tab.

Mock

https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/1adacef0-f245-4115-a0e0-d1c2e7d5a0bb/TP-Review-
@rt4914
Copy link
Contributor

rt4914 commented Feb 24, 2020

@veena14cs Please add description along with mock link. Also, In title, mention "Domain" as the first task will be to introduce that in domain layar.

@rt4914
Copy link
Contributor

rt4914 commented Feb 24, 2020

Also, assign it to yourself.

@veena14cs
Copy link
Contributor Author

@veena14cs Please add description along with mock link. Also, In title, mention "Domain" as the first task will be to introduce that in domain layar.

Okay.

@veena14cs veena14cs self-assigned this Feb 24, 2020
@veena14cs veena14cs changed the title Add thumbnails in Subtopic to show in Revision tab. Add thumbnails in Subtopic Domain layer to show in Revision tab. Feb 24, 2020
veena14cs added a commit that referenced this issue Feb 25, 2020
@veena14cs
Fix part #703: Domain Subtopic Thumbnail Introduction (#710)
ece0cb2 
* introduced thumbnail

* Update TopicControllerTest.kt

* fixed nit

* Update TopicControllerTest.kt
rt4914 pushed a commit that referenced this issue Feb 25, 2020
@veena14cs
Fix part #703: Introduce Subtopic thumbnail in app module (#711)
5e7fbe9 
* introduced thumbnail

* Update TopicControllerTest.kt

* fixed nit

* added thumbnail in app module

* Update TopicReviewFragmentTest.kt

* Update TopicReviewFragmentTest.kt

* Update TopicReviewFragmentTest.kt

* Update TopicControllerTest.kt

* Update TopicControllerTest.kt

* Update TopicControllerTest.kt

* Update TopicControllerTest.kt
@veena14cs
Copy link
Contributor Author

This is fixed in the PR #710 & #711 .

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rt4914 @BenHenning @veena14cs