Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowfi landscape Topic Revision #714

Closed
rt4914 opened this issue Feb 25, 2020 · 6 comments · Fixed by #794
Closed

Lowfi landscape Topic Revision #714

rt4914 opened this issue Feb 25, 2020 · 6 comments · Fixed by #794
Assignees
@abhinavraj23
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 25, 2020

Mock: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/dad2a9ff-ce33-4f00-894a-ec07dbb12797/TP-Revision-

Add test cases for the same.
@rt4914
Copy link
Contributor Author

rt4914 commented Feb 25, 2020

@abhinavraj23 This is not regular landscape UI, in this you will need to manage the layout manager and test cases will be critical. Test this across various device sizes.

@abhinavraj23
Copy link
Contributor

abhinavraj23 commented Feb 25, 2020 •
edited
Loading

Sure @rt4914 I would start working on it ASAP!

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 25, 2020

Sure @rt4914 I would start working on it ASAP!

Thanks.

@abhinavraj23
Copy link
Contributor

@rt4914 I think here we have to make the landscape layout for fragment inside a fragment, it's a bit complicated I guess, will take time, will try to complete it by tomorrow

@rt4914
Copy link
Contributor Author

rt4914 commented Mar 10, 2020

@abhinavraj23 Any updates on this issue.

@abhinavraj23
Copy link
Contributor

abhinavraj23 commented Mar 11, 2020 •
edited
Loading

@rt4914 sorry for the delay, will make the PR ASAP!

@abhinavraj23 abhinavraj23 mentioned this issue Mar 13, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Mar 19, 2020
@abhinavraj23
Fixes #714: Landscape version for Topic-Review Screen (#794)
e32377f 
* Made landscape version for topic-review

* Added condition to layout manager

* Removed unused imports

* Added tests

* Removed extra spaces

* Changed method for orientation change

* Removed unused imports
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinavraj23 abhinavraj23

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fixes #714: Landscape version for Topic-Review Screen abhinavraj23/oppia-android
3 participants
@rt4914 @BenHenning @abhinavraj23