Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highfi: Topic Overview #742

Closed
rt4914 opened this issue Mar 5, 2020 · 3 comments · Fixed by #757
Closed

Highfi: Topic Overview #742

rt4914 opened this issue Mar 5, 2020 · 3 comments · Fixed by #757
Assignees
@rt4914
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Mar 5, 2020

TopicOverview needs to be pixel perfect with the mocks.
Portrait Mock: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/19cfbacf-854c-4c7d-8691-3b3d117e1866/TP-Overview-

Landscape Mock: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/4e4d2aec-fd30-4c20-91ed-daf434f47a89/TP-Info-

Mocks have been created for MDPI Devices.
Make sure that the screen passes the accessibility test also.
For reference you can checkout: https://github.com/oppia/oppia-android/wiki/Working-on-UI
@rt4914
Copy link
Contributor Author

rt4914 commented Mar 5, 2020

Assigning this to @chrk2205

@rt4914 rt4914 self-assigned this Mar 5, 2020
@rt4914 rt4914 changed the title Hifi: Topic Overview Highfi: Topic Overview Mar 5, 2020
@chrk2205
Copy link
Contributor

chrk2205 commented Mar 7, 2020

bp
bL
before editing.

Ap
Al

After

Their are no much changes but i changed them according to UI-guide

This was referenced Mar 7, 2020
Closed
Merged
@chrk2205
Copy link
Contributor

chrk2205 commented Mar 7, 2020

@rt4914 please check my PR.

rt4914 pushed a commit that referenced this issue Mar 11, 2020
@chrk2205
Fix #742: highfi-topic-overview (#757)
d92f565 
* Fix #742 Hifi:Topic Overview

* Fix #742 : Highfi Topic Overview

* Fix #742 : Highfi Topic Overview

* Fix #742 : Highfi Topic Overview

* fix #742 : highfi-topic-overview

* Fix #742 : Highfi Topic Overview

* Fix #742 : Highfi Topic Overview
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #742: highfi-topic-overview
Highfi: Topic overview
3 participants
@rt4914 @BenHenning @chrk2205