Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowfi Landscape Review Card #773

Closed
rt4914 opened this issue Mar 10, 2020 · 2 comments · Fixed by #978
Closed

Lowfi Landscape Review Card #773

rt4914 opened this issue Mar 10, 2020 · 2 comments · Fixed by #978
Assignees
@abhinavraj23
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Mar 10, 2020 •
edited
Loading

Mock: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/5d907b23-a75e-4f8b-8c59-afd3c734c53e/RM-Revision-Mode-/

Review card is missing dummy data, also Return to Topic button is also missing at the bottom of the page.
Also, finish the landscape mode for the same, with proper test cases.
@rt4914 rt4914 added the Priority: Essential This work item must be completed for its milestone. label Mar 10, 2020
@rt4914 rt4914 changed the title Lowfi/Domain Review Card Lowfi Landscape Review Card Apr 13, 2020
@rt4914 rt4914 assigned abhinavraj23 and unassigned veena14cs Apr 13, 2020
@abhinavraj23
Copy link
Contributor

@rt4914 I have made the landscape version of the revision card please update regarding what dummy data do we need to add and what should be the layout for Return to Topic Button?

@abhinavraj23 abhinavraj23 mentioned this issue Apr 13, 2020
Merged
8 tasks
@rt4914
Copy link
Contributor Author

rt4914 commented Apr 14, 2020

@rt4914 I have made the landscape version of the revision card please update regarding what dummy data do we need to add and what should be the layout for Return to Topic Button?

@abhinavraj23

  1. I will take care of dummy data, so you can avoid that for now.
  2. If you scroll the mock, you will see Return to Topic button at the bottom.

rt4914 pushed a commit that referenced this issue Apr 20, 2020
@abhinavraj23
Fix #773: Made landscape layout for revision card (#978)
cf6e8d3 
* Made landscape verison for revision card

* Added return to topic button

* Made interface for return to topic

* Added tests

* Made requested changes

* Added remaining tests

* Fixed bug

* Minor changes
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhinavraj23 abhinavraj23

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #773: Made landscape layout for revision card abhinavraj23/oppia-android
4 participants
@rt4914 @BenHenning @veena14cs @abhinavraj23