Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowfi Landscape: OngoingTopicListActivity #791

Closed
rt4914 opened this issue Mar 12, 2020 · 6 comments · Fixed by #860
Closed

Lowfi Landscape: OngoingTopicListActivity #791

rt4914 opened this issue Mar 12, 2020 · 6 comments · Fixed by #860
Assignees
@rt4914
Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Mar 12, 2020

Mock: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/ce21cbf2-0439-47d7-bb37-005cfc6b9742/UP-Topics-in-Progress-

Also, please add test case for checking that item is visible in orientation change also. You will mainly need to do this in OngoingTopicListActivityTest
@rt4914 rt4914 changed the title Lowfi Landscape: Lowfi Landscape: OngoingTopicListActivity Mar 12, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Mar 12, 2020

Assigned to @virajpatel2411

@rt4914 rt4914 self-assigned this Mar 12, 2020
@virajpatel2411
Copy link
Contributor

@rt4914 Do I have to change anything in UI or I just have to add the test cases?

@rt4914
Copy link
Contributor Author

rt4914 commented Mar 12, 2020

@rt4914 Do I have to change anything in UI or I just have to add the test cases?

You will need to create the landscape layout, currently app supports only portrait mode. Also, for landscape mode you will need add test cases also. Check implementation in other activities which have landscape mode.

@virajpatel2411
Copy link
Contributor

Okaayy
And @rt4914 Where in the app will I find this page? I mean in the running app not in studio?

@rt4914
Copy link
Contributor Author

rt4914 commented Mar 13, 2020

Take latest, code from develop, inside Home - open navigationDrawer - Click on Profile - Click on Topics in Progress.

Now, you will be able to see that screen only when there is some progress in the app which obviously does not exists right now. So you can do this copy this code in HomeFragmentPresenter (Make sure this code is removed before you make a PR.)

Basically in this code we are using storyProgressHelper to mark fake progress in the app.

@virajpatel2411
Copy link
Contributor

Okay

This was referenced Mar 15, 2020
Closed
Closed
@rt4914 rt4914 mentioned this issue Mar 23, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Mar 24, 2020
@rt4914 @virajpatel2411
Fix #791 : Lowfi Landscape OngoingTopicListActivity (#860)
0fd610f 
* Fix Issue 791 : Landscape Mode for OngoingTopicListActivity created

* Test Case modified

* Test Case modified and Manifest updated for landscape mode

* Reverted HomeFragmentPresenter and removed unnecessary string value, Modified test case

* Typo in test case corrected

* Unnecessary new line removed

* Added test cases

* Nit changes

* Updated test cases

Co-authored-by: unknown <virajpatel2411@gmail.com>
Co-authored-by: Viraj Patel <36664384+virajpatel2411@users.noreply.github.com>
Co-authored-by: Rajat Talesra <talesra@talesra-macbookpro.roam.corp.google.com>
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
3 participants
@rt4914 @BenHenning @virajpatel2411