Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable all landscape tests in app module #968

Closed
rt4914 opened this issue Apr 13, 2020 · 2 comments · Fixed by #1016
Closed

Reenable all landscape tests in app module #968

rt4914 opened this issue Apr 13, 2020 · 2 comments · Fixed by #1016
Assignees
@SayantanBanerjee16
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Apr 13, 2020

In app module there are test cases which are getting ignored right now because of landscape feature. Now we can reenable all these test cases. You can find these test cases by this line in various files:
@Ignore("Landscape not properly supported") // TODO(#56): Reenable once landscape is supported.

Note: You have to focus on app module tests only.
@SayantanBanerjee16
Copy link
Contributor

@rt4914 Can I work on this issue?

@rt4914
Copy link
Contributor Author

rt4914 commented Apr 24, 2020

@rt4914 Can I work on this issue?

@SayantanBanerjee16 Yeah sure. Update: I do think that it should be almost finished but this issue has been kept to verify that correctly. Thanks.

@rt4914 rt4914 added Workstream: Lowfi UI Priority: Essential This work item must be completed for its milestone. labels Apr 24, 2020
@SayantanBanerjee16 SayantanBanerjee16 mentioned this issue Apr 24, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Apr 27, 2020
@SayantanBanerjee16
Fix #968 : Reenable all landscape tests in app module (#1016)
cbd5de6 
* ConceptCardFragmentTest landscape tests fixed

* nit update
@BenHenning BenHenning added this to the Alpha milestone Jun 23, 2020
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SayantanBanerjee16 SayantanBanerjee16

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #968 : Reenable all landscape tests in app module SayantanBanerjee16/oppia-android
4 participants
@MohamedMedhat1998 @rt4914 @BenHenning @SayantanBanerjee16