Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some nit changes #1187

Merged
merged 1 commit into from
May 29, 2020
Merged

Some nit changes #1187

merged 1 commit into from
May 29, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 29, 2020

Explanation

This PR does not contain any issue number as no issue can make sure that nit changes are completely fixed as of now. So for now, I have fixed the files in which I was aware of the changes.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@MohamedMedhat1998 MohamedMedhat1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But the non_flaky_tests of circle ci fails.

@rt4914 rt4914 merged commit 2fc549c into develop May 29, 2020
@rt4914 rt4914 deleted the nit-fixes-in-app-part-1 branch May 29, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants