-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #1267: Added newInstance function in TopicInfoFragment #1280
Fixes part of #1267: Added newInstance function in TopicInfoFragment #1280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice but the function is not getting used anywhere, left some comments accodingly.
app/src/main/java/org/oppia/app/topic/info/TopicInfoFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/topic/info/TopicInfoFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/topic/info/TopicInfoFragment.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I will defer to @rt4914 and @nikitamarysolomanpvt for the structure of this
@sajalasati The Title of the PR should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, besides the naming of argument key for example PROFILE_ID_ARGUMENT_KEY. Hope this will be handled in another PR.
Looks like tests pass so I am merging this PR now |
Explanation
Partly fixes #1267.
I have added a
newInstance
function in theTopicInfoFragment
file as part of the code optimization suggested in the issue.I request @vinitamurthi @nikitamarysolomanpvt @rt4914 to please this review this.
Checklist