Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes part of #1096: Crashlytics in Domain layer. #1319

Merged
merged 40 commits into from
Jun 15, 2020
Merged

Fixes part of #1096: Crashlytics in Domain layer. #1319

merged 40 commits into from
Jun 15, 2020

Conversation

Sarthak2601
Copy link
Contributor

@Sarthak2601 Sarthak2601 commented Jun 14, 2020 •
edited
Loading

Explanation

Fixes part of #1096

  • Added crashlytics implementation in domain module
  • Added tests for the implementation.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Sarthak2601 and others added 30 commits June 1, 2020 14:43
@Sarthak2601
crashlytics wrapper
8d50619
@Sarthak2601
wrapper check
c3b97eb
@vinitamurthi
Test implementation of crashlytics mocks
fc73449
@Sarthak2601
Crashlytics Wrapper in utility
7eee6a5
@Sarthak2601
nits
b71d8eb
@Sarthak2601
nits
ce39c92
@Sarthak2601
nit
682c5a7
@Sarthak2601
Firebase config file and dependency changes
96b3fe5
@Sarthak2601
nits
af362b8
@Sarthak2601
nits | renaming of wrapper
1291c04
@Sarthak2601
nits + interface
1e50e5e
@Sarthak2601
ktlint nits
ef941b4
@Sarthak2601
json deletion for seperate PR
26b5afd
@Sarthak2601
new testing approach
00866d4
@Sarthak2601
Merge branch 'develop' into crashlytics_wrapper
7097fa1
@Sarthak2601
new testing approach
e02be67
@Sarthak2601
nits
9ab53f2
@Sarthak2601
changes
bfbc746
@Sarthak2601
changes
fcd8bf8
@Sarthak2601
testing related changes.
62a1e7f
@Sarthak2601
Merge branch 'develop' into crashlytics_wrapper
84517a8
@Sarthak2601
Tests.
bd8737e
@Sarthak2601
Merge remote-tracking branch 'origin/crashlytics_wrapper' into crashl…
0033e7a 
…ytics_wrapper
@Sarthak2601
module addition in domain files.
db9a32e
@Sarthak2601
Merge branch 'develop' into crashlytics_wrapper
5ef8dd4
@Sarthak2601
Merge branch 'develop' into crashlytics_wrapper
be040f1
@Sarthak2601
lint fix
baf0d00
@Sarthak2601
changes.
1155611
@Sarthak2601
testLogReportingModule in app module
b747379
@Sarthak2601
Robolectric tests passing.
4fecd09
@Sarthak2601 Sarthak2601 self-assigned this Jun 14, 2020
vinitamurthi
vinitamurthi approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@vinitamurthi vinitamurthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of nits!

domain/src/main/java/org/oppia/domain/classify/AnswerClassificationController.kt Outdated Show resolved Hide resolved
domain/src/test/java/org/oppia/domain/classify/AnswerClassificationControllerTest.kt Outdated Show resolved Hide resolved
domain/src/test/java/org/oppia/domain/topic/TopicControllerTest.kt Outdated Show resolved Hide resolved
@vinitamurthi vinitamurthi removed their assignment Jun 15, 2020
@Sarthak2601
Copy link
Contributor Author

All comments resolved, checks passed. Merging now :)

@Sarthak2601 Sarthak2601 merged commit cefb9cc into develop Jun 15, 2020
@Sarthak2601 Sarthak2601 deleted the exception-log-implementation branch June 15, 2020 09:24
@Sarthak2601 Sarthak2601 linked an issue Jun 15, 2020 that may be closed by this pull request
Add Crashlytics Wrapper for crash reporting [GSoC'20][Milestone 1] #1096
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitamurthi vinitamurthi vinitamurthi approved these changes

Assignees

@Sarthak2601 Sarthak2601

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Crashlytics Wrapper for crash reporting [GSoC'20][Milestone 1]
2 participants
@Sarthak2601 @vinitamurthi