Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #1317: Fix lint issues in domain module in the kotlin files (classify test) #1354

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Fix part of #1317: Fix lint issues in domain module in the kotlin files (classify test) #1354

merged 3 commits into from
Jun 22, 2020

Conversation

anandwana001
Copy link
Contributor

Explanation

Fixes part of #1317
classify test package ktlint check

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 requested review from rt4914, veena14cs and vinitamurthi and removed request for rt4914 June 18, 2020 09:35
veena14cs
veena14cs approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check there is one lint error.

@veena14cs veena14cs removed their assignment Jun 19, 2020
@anandwana001
Merge branch 'develop' of https://github.com/oppia/oppia-android into…
acbd6d7 
… classify-test-domain-ktlint-check

# Conflicts:
#	data/src/test/java/org/oppia/data/persistence/PersistentCacheStoreTest.kt
@vinitamurthi
Copy link
Contributor

Merging this

@vinitamurthi vinitamurthi merged commit 475e4ac into oppia:develop Jun 22, 2020
@anandwana001
Copy link
Contributor Author

Merging this

Thanks for merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitamurthi vinitamurthi vinitamurthi approved these changes

@veena14cs veena14cs veena14cs approved these changes

Assignees

@vinitamurthi vinitamurthi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anandwana001 @vinitamurthi @veena14cs