Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1346: Added test cases ExplorationTestActivity #1361

Merged
merged 3 commits into from
Jun 19, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 18, 2020

Explanation

Fixes #1346

This PR adds some test cases for landscape mode of ExplorationActivity.
The AudioPlayer is a complicated issue and currently does not support orientation change and therefore a separate issue has been filed for that. #1360

NOTE: Run these test cases on real device and if any test case fails on emulator, run it again, it should passes easily.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jun 18, 2020
@rt4914 rt4914 merged commit 232cafc into develop Jun 19, 2020
@rt4914 rt4914 deleted the exploration-activity-landscape-test-cases branch June 19, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lowfi landscape Exploration/State
2 participants