Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1366: Fix bottom paddings in scrollable screens (Tablet) #1375

Merged
merged 4 commits into from
Jun 23, 2020

Conversation

MohamedMedhat1998
Copy link
Contributor

Explanation

Note

In the case of home_fragment.xml the bottom padding is 100dp only. This is because in the TopicListAdapter the last item in the screen has a padding of 12dp. So, the total bottom padding will be 100 + 12 = 112 which is the required value .

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned MohamedMedhat1998 and unassigned rt4914 Jun 22, 2020
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 assigned MohamedMedhat1998 and unassigned rt4914 Jun 23, 2020
@MohamedMedhat1998 MohamedMedhat1998 merged commit abeb7f4 into develop Jun 23, 2020
@MohamedMedhat1998 MohamedMedhat1998 deleted the bottom-paddings-part1 branch June 23, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bottom paddings in scrollable screens (Tablet)
2 participants