-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #141 & Fix #1392: Update topic description #1395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@rt4914 What if the text is a bit long like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
nit changes to prevent ktlint
failure.
app/src/main/java/org/oppia/app/topic/info/TopicInfoFragmentPresenter.kt
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/topic/info/TopicInfoFragmentTest.kt
Show resolved
Hide resolved
This is correct, text length has been controlled correctly in app as well as the oppia backend. |
Explanation
Fixes #141 & #1392
Currently in develop, the topic description in InfoFragment supports rich text and this PR removes that support because topic description will be plain text only.
Note: I have just removed one particular test case in this and if you want to run/check the existing test cases you can run that specifically on Nexus S device because at the time of development of this PR that device was finalised for testing purposes. On other high-end devices these test cases will fail and it can only be fixed once #1379 is finished.
Before
After
Checklist