Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #141 & Fix #1392: Update topic description #1395

Merged
merged 5 commits into from
Jun 30, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 24, 2020

Explanation

Fixes #141 & #1392

Currently in develop, the topic description in InfoFragment supports rich text and this PR removes that support because topic description will be plain text only.

Note: I have just removed one particular test case in this and if you want to run/check the existing test cases you can run that specifically on Nexus S device because at the time of development of this PR that device was finalised for testing purposes. On other high-end devices these test cases will fail and it can only be fixed once #1379 is finished.

Before

Screenshot_1592992943

After

Screenshot_1592991802

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veena14cs veena14cs removed their assignment Jun 24, 2020
@anandwana001
Copy link
Contributor

@rt4914 What if the text is a bit long like this?
is this good to go or we should have some max length limit and leave some space at the end to look it good?
Screenshot_1593004123

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
nit changes to prevent ktlint failure.

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jun 24, 2020
@rt4914
Copy link
Contributor Author

rt4914 commented Jun 29, 2020

@rt4914 What if the text is a bit long like this?
is this good to go or we should have some max length limit and leave some space at the end to look it good?
Screenshot_1593004123

This is correct, text length has been controlled correctly in app as well as the oppia backend.

@rt4914 rt4914 merged commit 8b976b3 into develop Jun 30, 2020
@rt4914 rt4914 deleted the topic-description-update branch June 30, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final UI: Topic overview tab fragment [Blocked: #15, #136]
3 participants