Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1398: Set minimum image size to 48dp #1396

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Fix #1398: Set minimum image size to 48dp #1396

merged 2 commits into from
Jun 25, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 24, 2020

Explanation

Fixes #1398

This PR makes sure that the image size in rich-text is atleast 48dpx48dp while maintaining its original aspect ratio.

Before

Screenshot_1592995063

After

Screenshot_1592995342

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from veena14cs June 24, 2020 10:46
veena14cs
veena14cs approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914! LGTM.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jun 24, 2020
@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Jun 24, 2020
@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Jun 25, 2020
@rt4914 rt4914 merged commit 43d5ff9 into develop Jun 25, 2020
@rt4914 rt4914 deleted the minimum-ikmage-size branch June 25, 2020 07:42
rt4914 added a commit that referenced this pull request Jun 25, 2020
@rt4914
Revert "Fix #1398: Set minimum image size to 48dp (#1396)"
94db40d 
This reverts commit 43d5ff9.
This was referenced Jun 25, 2020
Merged
Merged
rt4914 added a commit that referenced this pull request Jun 26, 2020
@rt4914
Revert "Fix #1398: Set minimum image size to 48dp (#1396)" (#1401)
2e9b386 
This reverts commit 43d5ff9.
@rt4914 rt4914 mentioned this pull request Jun 26, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veena14cs veena14cs veena14cs approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rt4914 @veena14cs