Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #1028: Add ProfileProgress app tests to the non-flaky queue #1400

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Fix part of #1028: Add ProfileProgress app tests to the non-flaky queue #1400

merged 2 commits into from
Jun 26, 2020

Conversation

veena14cs
Copy link
Contributor

Explanation

This PR adds tests in the ProfileProgress directories of the app module to the non-flaky queue
Fixes part of #1028

@vinitamurthi vinitamurthi removed their assignment Jun 25, 2020
anandwana001
anandwana001 approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
can we put space equally, FAQ, Help, Mydownloads, Parser,Profileprogress!! although there are no checks on this file so not an issue.

@veena14cs
Copy link
Contributor Author

LGTM
can we put space equally, FAQ, Help, Mydownloads, Parser,Profileprogress!! although there are no checks on this file so not an issue.

Done.

@anandwana001
Copy link
Contributor

LGTM
can we put space equally, FAQ, Help, Mydownloads, Parser,Profileprogress!! although there are no checks on this file so not an issue.

Done.

Thanks for update :)

@veena14cs veena14cs merged commit dcdf6f6 into develop Jun 26, 2020
@veena14cs veena14cs deleted the circle-ci-profile-tests branch June 26, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitamurthi vinitamurthi vinitamurthi approved these changes

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@veena14cs veena14cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veena14cs @anandwana001 @vinitamurthi