Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #1433: Rename the logger class to consoleLogger #1434

Merged
merged 6 commits into from
Jul 2, 2020

Conversation

vinitamurthi
Copy link
Contributor

Explanation

With the new forms of firebase logging coming up, we would like app/domain module files to use all logging functionality from a single logger. This PR starts the work of it. See the issue for details on how we intend to restructure it.
Fixes part of #1433

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914 rt4914 removed their assignment Jul 1, 2020
Copy link
Contributor

@Sarthak2601 Sarthak2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one suggestion, shouldn't we rename the variable name to consoleLogger as well ? I think It would make files more readable in cases where multiple logging scenarios(console/event/exception) exist in the same file.

@Sarthak2601 Sarthak2601 removed their assignment Jul 1, 2020
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thing to confirm this is updated with our yesterday's ktlint app module check merge.

@vinitamurthi
Copy link
Contributor Author

LGTM. Just one suggestion, shouldn't we rename the variable name to consoleLogger as well ? I think It would make files more readable in cases where multiple logging scenarios(console/event/exception) exist in the same file.

The whole goal is to remove multiple logging scenarios :) Hence I am not changing the name. Eventually we will be replacing the consoleLogger with OppiaLogger in the app and domain modules, so I dont want to change variable names right now

@vinitamurthi
Copy link
Contributor Author

LGTM, just one thing to confirm this is updated with our yesterday's ktlint app module check merge.

Yep I updated the branch

@vinitamurthi vinitamurthi merged commit 0577e57 into oppia:develop Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants