Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #989: Crash on Profile edit page landscape. #989 #1446

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

anandwana001
Copy link
Contributor

@anandwana001 anandwana001 commented Jul 7, 2020

Explanation

Fix #989
Moved the Dialog opening implementation from Activity Presenter to Fragment Presenter as dialog is a part of the fragment. Retaining the instance of fragment fix the crash of the fragment manager destroyed when the screen rotates.

For reviewer

  1. Codebase implementation in terms of architecture
  2. Install app -> open profile -> click on edit image -> rotate -> no crash
  3. Install app -> open profile -> rotate -> click on edit image -> no crash

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Jul 8, 2020
@rt4914
Copy link
Contributor

rt4914 commented Jul 8, 2020

@anandwana001 Just update this branch and it will be good to merge.

@rt4914 rt4914 merged commit fdf2e4f into oppia:develop Jul 8, 2020
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on Profile edit page landscape.
2 participants