Fixes 1432: Fix prototype exploration answer #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarwalpulkit596
changed the title
BenHenning
reviewed
Jul 13, 2020
| @@ -705,7 +705,7 @@ class StateFragmentTest { | |||
| onView(withId(R.id.submit_answer_button)).perform(click()) | |||
| onView(withId(R.id.continue_navigation_button)).perform(click()) | |||
|
|
|||
| // Seventh state: Drag Drop Sort. Correct answer: Move 1st item to 3rd position. | |||
| // Seventh state: Drag Drop Sort. Correct answer: Move 1st item to 4rd position. | |||
BenHenning
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Thanks for the quick fix @aggarwalpulkit596! LGTM minus some nits.
| @@ -849,7 +849,7 @@ | |||
| }, | |||
| "content": { | |||
| "content_id": "content", | |||
| "html": "<p>Sort the following in ascending order, putting equal items in the same position.</p>" | |||
| "html": "<p>Sort the following in descending order, putting equal items in the same position.</p>" | |||
There was a problem hiding this comment.
I think that the first drag & drop state also says 'putting equal items in the same position' but grouping isn't enabled for it. Can you please fix the text accordingly?
| @@ -705,7 +705,7 @@ class StateFragmentTest { | |||
| onView(withId(R.id.submit_answer_button)).perform(click()) | |||
| onView(withId(R.id.continue_navigation_button)).perform(click()) | |||
|
|
|||
| // Seventh state: Drag Drop Sort. Correct answer: Move 1st item to 3rd position. | |||
| // Seventh state: Drag Drop Sort. Correct answer: Move 1st item to 4rd position. | |||
There was a problem hiding this comment.
You added another action here (e.g. you seem to be moving two things here); please clarify in the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #1432
Checklist