Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #1460: Json file updates for questions and skills #1489

Merged
merged 8 commits into from
Jul 21, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 21, 2020

Explanation

This PR fixes part of #1460

Checklist

  • All questions are shifted to a single questions.json file.
  • All questions are shifted to a single skills.json file.

Pending

  • Structure of question json files needs to be updated. (Will be done in future PR)
  • Topic Size Calculation.

How to test:

  1. All tests are passing without major change makes sure that the content is parsing correctly.
  2. Run the app, go to Fractions-> Practice, start questions.
  3. Make ConceptCardFragmentTestActivity as launcher activity and check that it works.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nit changes

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 21, 2020
@rt4914 rt4914 merged commit e5470fa into develop Jul 21, 2020
@rt4914 rt4914 deleted the json-file-updates-questions-and-skills branch July 21, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants