Fix part of #40 & #42: Generalisation mobile devices - Content View - Portrait #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedMedhat1998
suggested changes
Jul 26, 2020
app/src/main/java/org/oppia/app/databinding/StateAssemblerMarginBindingAdapters.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/StateAssemblerMarginBindingAdapters.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/StateAssemblerMarginBindingAdapters.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/StateAssemblerMarginBindingAdapters.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/StateAssemblerPaddingBindingAdapters.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/StateAssemblerPaddingBindingAdapters.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/StateAssemblerPaddingBindingAdapters.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/StateAssemblerPaddingBindingAdapters.kt
Outdated
Show resolved
Hide resolved
|
The margins in this reference is different from the mocks: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/9ea1d153-06e3-434f-9bf7-d582d48583b1/specs/ |
Actually, the mocks are inconsistent, that's why we have received this from Chantel, in an email thread. |
added 2 commits
July 26, 2020 16:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR finishes the highfi work of
ContentView-Portrait Modefor mobile devices only.Note, the strategy that I have followed for margins is that we we introduce only top-start-end margins and bottom margin won't be introduced (as bottom margin for item1 can be treated as top margin for item-2).
Note: When you run the app, it might seem that the text size is small, so to fix that, go to
Options -> StoryTextSizeand set it to medium.Reference:
Screenshots
Checklist