-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes part of #59: Translate binding adapter files to java [BLOCKED: #1514] #1568
Conversation
app/src/main/java/org/oppia/app/databinding/TextViewBindingAdapters.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/TextViewBindingAdapters.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miaboloix! Generally LGTM, though there are a few lingering comment threads to resolve before merging into develop.
… introduce-domain-bazel-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @miaboloix
…ia/oppia-android into traslate-binding-adapters-to-java
… traslate-binding-adapters-to-java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @miaboloix! Just had two nits that you can resolve once their corresponding requests are done. Please let me know if I need to clarify anything.
app/src/main/java/org/oppia/app/databinding/TextViewBindingAdapters.java
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/databinding/TextViewBindingAdapters.java
Outdated
Show resolved
Hide resolved
…pters.java Co-authored-by: Ben Henning <henning.benmax@gmail.com>
…m/oppia/oppia-android into traslate-binding-adapters-to-java
Explanation
Fixes part of #59: Translate binding adapter files to java
Because
kt_android_library()
is split intoandroid_library
andkt_jvm_library
under the hood -- it has been difficult to get custom Binding Adapters in Kotlin to build with Bazel + databinding. The current workaround for this is to translate our binding adapter files to Java so that they can build usingandroid_library()
, which now supports databinding. See bazelbuild/rules_kotlin#346 and bazelbuild/bazel#2694Checklist