-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1507 : Added IsEquivalent Classifier Rule #1670
Conversation
Please resolve the conflicts, ensure the branching is correct for Oppia Android, and send back my way once the interaction object structure is updated. |
Hi Pulkit, I am going to defer to @BenHenning for review of this because I don't think I have enough context for semantic correctness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aggarwalpulkit596! Took a pass.
...a/domain/classify/rules/ratioExpressionInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
...a/domain/classify/rules/ratioExpressionInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
...a/domain/classify/rules/ratioExpressionInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
...a/domain/classify/rules/ratioExpressionInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
...g/oppia/domain/classify/rules/ratioInput/RatioInputIsEquivalentRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...a/domain/classify/rules/ratioExpressionInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
...g/oppia/domain/classify/rules/ratioInput/RatioInputIsEquivalentRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...g/oppia/domain/classify/rules/ratioInput/RatioInputIsEquivalentRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...g/oppia/domain/classify/rules/ratioInput/RatioInputIsEquivalentRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
...g/oppia/domain/classify/rules/ratioInput/RatioInputIsEquivalentRuleClassifierProviderTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Took another pass.
...a/org/oppia/domain/classify/rules/ratioInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
...a/org/oppia/domain/classify/rules/ratioInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
...a/domain/classify/rules/ratioExpressionInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
...a/domain/classify/rules/ratioExpressionInput/RatioInputIsEquivalentRuleClassifierProvider.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # domain/src/main/java/org/oppia/domain/classify/rules/ratioinput/RatioInputIsEquivalentRuleClassifierProvider.kt # domain/src/test/java/org/oppia/domain/classify/rules/ratioinput/RatioInputIsEquivalentRuleClassifierProviderTest.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aggarwalpulkit596. This LGTM.
Explanation
Fixes #1507
Checklist