Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1507 : Added IsEquivalent Classifier Rule #1670

Merged
merged 28 commits into from
Aug 25, 2020

Conversation

aggarwalpulkit596
Copy link
Contributor

Explanation

Fixes #1507

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@BenHenning
Copy link
Member

Please resolve the conflicts, ensure the branching is correct for Oppia Android, and send back my way once the interaction object structure is updated.

@vinitamurthi
Copy link
Contributor

Hi Pulkit, I am going to defer to @BenHenning for review of this because I don't think I have enough context for semantic correctness

@vinitamurthi vinitamurthi removed their assignment Aug 18, 2020
@aggarwalpulkit596 aggarwalpulkit596 changed the base branch from develop to ratio-input-module August 18, 2020 04:10
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aggarwalpulkit596! Took a pass.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Took another pass.

# Conflicts:
#	domain/src/main/java/org/oppia/domain/classify/rules/ratioinput/RatioInputIsEquivalentRuleClassifierProvider.kt
#	domain/src/test/java/org/oppia/domain/classify/rules/ratioinput/RatioInputIsEquivalentRuleClassifierProviderTest.kt
Base automatically changed from ratio-input-module to develop August 25, 2020 06:20
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aggarwalpulkit596. This LGTM.

@aggarwalpulkit596 aggarwalpulkit596 merged commit 5c2bdba into develop Aug 25, 2020
@aggarwalpulkit596 aggarwalpulkit596 deleted the ratio-equivalent-rule branch August 25, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add classifiers isEquivalentTo
3 participants