Fix part of #59: Adding Bazel build to CI checks [BLOCKED: #1634] #1688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stage1_bazel_utility
…-android into stage1_bazel_testing
…-android into introduce-bazel-roboelectric-testing
…-android into introduce-bazel-roboelectric-testing
….com/oppia/oppia-android into introduce-domain-bazel-build
…ia/oppia-android into traslate-binding-adapters-to-java
…ia/oppia-android into traslate-binding-adapters-to-java
This reverts commit 84037cb.
This reverts commit ce92d0a.
This reverts commit 88c9492.
This reverts commit d66af07.
8 tasks
BenHenning
requested changes
Aug 22, 2020
There was a problem hiding this comment.
Actually, I found one issue. Per the checks tab, it seems the APK failed to upload:
No files were found with the provided path: $GITHUB_WORKSPACE/oppia.apk. No artifacts will be uploaded.
I suppose this one reference might need to be absolute instead of relative.
Co-authored-by: Ben Henning <henning.benmax@gmail.com>
Co-authored-by: Ben Henning <henning.benmax@gmail.com>
Co-authored-by: Ben Henning <henning.benmax@gmail.com>
|
LGTM from code perspective. Just waiting to see the upload get fixed |
BenHenning
reviewed
Aug 22, 2020
BenHenning
approved these changes
Aug 22, 2020
… introduce-bazel-binary-build-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fix part of #59: Adding Bazel build to CI checks [BLOCKED: #1634]
This PR introduces a CI check that builds Oppia Android's apk with Bazel.
Please note that this PR is replacing this one.