Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS #1713

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Create CODEOWNERS #1713

merged 1 commit into from
Aug 26, 2020

Conversation

BenHenning
Copy link
Member

@BenHenning BenHenning commented Aug 26, 2020

Create CODEOWNERS, initially just for Bazel files since these require specific knowledge in order to review & verify.

The framework of the file is loosely based on https://github.com/oppia/oppia/blob/develop/.github/CODEOWNERS.

Create CODEOWNERS, initially just for Bazel files since these require specific knowledge in order to review & verify.
@BenHenning
Copy link
Member Author

/cc @miaboloix

@vinitamurthi
Copy link
Contributor

Should we add codeowners for the CI as well now (i.e. Github actions)? Or we can do that in a follow up, its upto you!

@vinitamurthi vinitamurthi removed their assignment Aug 26, 2020
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. LGTM

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Aug 26, 2020
@BenHenning
Copy link
Member Author

@vinitamurthi that's a good idea, but let's do it in a follow-up to make tracking a bit easier.

Thanks both for the review!

@BenHenning BenHenning merged commit 8491082 into develop Aug 26, 2020
@BenHenning BenHenning deleted the introduce-codeowners branch August 26, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants