-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1767: Revert "Fixes part of #40 & #42: Generalisation Highfi Mobile Portrait + Landscape - Buttons" #1768
Fix #1767: Revert "Fixes part of #40 & #42: Generalisation Highfi Mobile Portrait + Landscape - Buttons" #1768
Conversation
@BenHenning This will block alpha but it should be doable in less time now because I have mentioned margins/paddings in comments in each button files which makes it easy to implement. |
@rt4914 can you clarify why this blocks alpha? In general, most hi-fi tasks don't block alpha unless they inhibit the core user experience. |
The reason behind mentioning that this will block alpha is because all other items like But I ran the app and saw it does not look that bad without this PR. So it won't block alpha |
Thanks for clarifying @rt4914. That sounds good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Thanks @rt4914! |
…le Portrait + Landscape - Buttons (oppia#1653)" (oppia#1768) This reverts commit 1bb1ffa.
Reverts #1653
Fixes #1767
This is a clean revert.