Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1767: Revert "Fixes part of #40 & #42: Generalisation Highfi Mobile Portrait + Landscape - Buttons" #1768

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

BenHenning
Copy link
Member

@BenHenning BenHenning commented Sep 2, 2020

Reverts #1653
Fixes #1767

This is a clean revert.

…t + Landscape - Buttons (#1653)"

This reverts commit 1bb1ffa.
@BenHenning
Copy link
Member Author

We will need to reopen #40 and #42. @rt4914 are there any aspects that were fixed in the original PR that will block alpha?

@rt4914
Copy link
Contributor

rt4914 commented Sep 2, 2020

We will need to reopen #40 and #42. @rt4914 are there any aspects that were fixed in the original PR that will block alpha?

@BenHenning This will block alpha but it should be doable in less time now because I have mentioned margins/paddings in comments in each button files which makes it easy to implement.

@BenHenning
Copy link
Member Author

BenHenning commented Sep 2, 2020

@rt4914 can you clarify why this blocks alpha? In general, most hi-fi tasks don't block alpha unless they inhibit the core user experience.

@rt4914
Copy link
Contributor

rt4914 commented Sep 2, 2020

@rt4914 can you clarify why this blocks alpha? In general, most hi-fi tasks don't block alpha unless they inhibit the core user experience.

The reason behind mentioning that this will block alpha is because all other items like ContentView, FeedbackView, Interactions are already done and because of which the buttons UI might look a bit off.

But I ran the app and saw it does not look that bad without this PR. So it won't block alpha

Screenshot_1599043146

@BenHenning
Copy link
Member Author

Thanks for clarifying @rt4914. That sounds good.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned BenHenning and unassigned rt4914 Sep 2, 2020
@BenHenning
Copy link
Member Author

Thanks @rt4914!

@BenHenning BenHenning merged commit 60d8101 into develop Sep 2, 2020
@BenHenning BenHenning deleted the revert-1653-state-recycler-view-buttons-highfi branch September 2, 2020 19:09
prayutsu pushed a commit to prayutsu/oppia-android that referenced this pull request Sep 3, 2020
…le Portrait + Landscape - Buttons (oppia#1653)" (oppia#1768)

This reverts commit 1bb1ffa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to input answers in landscape is impossible due to keyboard automatically dismissing.
2 participants