Fix #1779: Updated placeholder schema #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rt4914
changed the title
BenHenning
requested changes
Sep 3, 2020
There was a problem hiding this comment.
Thanks @rt4914! Do NumericInput and FractionInput also need to change?
app/src/main/java/org/oppia/app/player/state/itemviewmodel/TextInputViewModel.kt
Outdated
Show resolved
Hide resolved
BenHenning
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
Thanks @rt4914! LGTM--my only comment isn't suggesting any changes, so feel free to resolve after reading it.
| @@ -1444,7 +1445,8 @@ class StateFragmentTest { | |||
|
|
|||
| fun inject(stateFragmentTest: StateFragmentTest) | |||
|
|
|||
| @IsOnRobolectric fun isOnRobolectric(): Boolean | |||
There was a problem hiding this comment.
FYI this is technically conformant to our style guide: https://developer.android.com/kotlin/style-guide#annotations & ktlint normally seems amenable to it.
|
Actually @rt4914 going to go ahead and merge this since it'd be nice to pick it up in the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #1779
This PR updates the schema of
placeholdertext.NOTE: The placeholder-texts might be slightly different but that should not be an issue because this is dummy content.
Also, I think we should add one test in
appmodule related to hint visibility but that depends on #1630 getting merged.Result can be seen in the form of hints in various explorations.
Checklist