Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1809: Fix Reveal Solution Dialog #1822

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Sep 8, 2020

Explanation

Fixes #1809

Output

reveal_solution

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 marked this pull request as ready for review September 8, 2020 08:25
@rt4914 rt4914 changed the title Fix #1809: Fix Reveal Solution Dialog [WIP] Fix #1809: Fix Reveal Solution Dialog Sep 8, 2020
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @rt4914

@rt4914 rt4914 merged commit 6f523f2 into develop Sep 9, 2020
@rt4914 rt4914 deleted the fix-reveal-solution-dialog branch September 9, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on "Cancel" in Reveal Solution Dialog, shows the solution
2 participants