Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1976: Optimize code in administrator_controls_general_view.xml #2005

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Fix #1976: Optimize code in administrator_controls_general_view.xml #2005

merged 2 commits into from
Oct 13, 2020

Conversation

Florence-Njeri
Copy link
Contributor

@Florence-Njeri Florence-Njeri commented Oct 13, 2020 •
edited
Loading

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@Florence-Njeri Florence-Njeri changed the title Fixes #1976: Optimize code in administrator_controls_general_view.xml Fix #1976: Optimize code in administrator_controls_general_view.xml Oct 13, 2020
rt4914
rt4914 suggested changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. You can just remove layout_height too as per below comments.

Thanks.

app/src/main/res/layout-land/administrator_controls_general_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout-land/administrator_controls_general_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout-sw600dp/administrator_controls_general_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout-sw600dp/administrator_controls_general_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/administrator_controls_general_view.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/administrator_controls_general_view.xml Outdated Show resolved Hide resolved
@rt4914
Copy link
Contributor

rt4914 commented Oct 13, 2020

@Florence-Njeri PTAL (Please take a look)

@Florence-Njeri
remove "android:layout_height">wrap_content from TextViews in adminis…
f41ec87 
…trator_controls_general_view.xml since it is already present in the styles that extend from Common1
@Florence-Njeri
Copy link
Contributor Author

@Florence-Njeri PTAL (Please take a look)
@rt4914
Done

@rt4914
Copy link
Contributor

rt4914 commented Oct 13, 2020

@Florence-Njeri Make sure you always reply to the comments.

rt4914
rt4914 approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit e190413 into oppia:develop Oct 13, 2020
@Florence-Njeri
Copy link
Contributor Author

@Florence-Njeri Make sure you always reply to the comments.

I will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

@MohamedMedhat1998 MohamedMedhat1998 Awaiting requested review from MohamedMedhat1998

Assignees

@Florence-Njeri Florence-Njeri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimise code in administrator_controls_general_view.xml
3 participants
@Florence-Njeri @rt4914 @MohamedMedhat1998