Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2352: Update Ktlint version to "0.37.1" #2353

Merged
merged 2 commits into from
Dec 31, 2020
Merged

Fix #2352: Update Ktlint version to "0.37.1" #2353

merged 2 commits into from
Dec 31, 2020

Conversation

srikanthkb
Copy link
Contributor

@srikanthkb srikanthkb commented Dec 30, 2020 •
edited
Loading

Explanation

Fixes #2352

Updated the Ktlint download version in github workflows from "0.37.0" to 0.37.1"

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@srikanthkb
Fix oppia#2352: Update Ktlint version to "0.40.0"
993c7ce 
Fixes oppia#2352

Updated the Ktlint download version in workflows
from "0.37.0" to 0.40.0"
FareesHussain
FareesHussain suggested changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@FareesHussain FareesHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Srikanth-Kb PTAL

.github/workflows/main.yml Outdated Show resolved Hide resolved
@srikanthkb
Fix oppia#2352: Update Ktlint version to "0.37.1"
8c143a3 
Fixes oppia#2352

Updated the Ktlint download version in workflows
from "0.37.0" to 0.37.1". This version runs successfully
on Windows 10 OS.
anandwana001
anandwana001 approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Srikanth-Kb
Also, please update the issue and pr title for 0.37.1

FareesHussain
FareesHussain approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@FareesHussain FareesHussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@srikanthkb srikanthkb changed the title Fix #2352: Update Ktlint version to "0.40.0" Fix #2352: Update Ktlint version to "0.37.1" Dec 31, 2020
@srikanthkb
Copy link
Contributor Author

LGTM, Thanks @Srikanth-Kb
Also, please update the issue and pr title for 0.37.1

@srikanthkb srikanthkb closed this Dec 31, 2020
@srikanthkb
Copy link
Contributor Author

LGTM, Thanks @Srikanth-Kb
Also, please update the issue and pr title for 0.37.1

@srikanthkb srikanthkb reopened this Dec 31, 2020
@srikanthkb
Copy link
Contributor Author

Done.

rt4914
rt4914 approved these changes Dec 31, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 enabled auto-merge (squash) December 31, 2020 05:52
@rt4914 rt4914 removed their assignment Dec 31, 2020
@rt4914 rt4914 merged commit 520472f into oppia:develop Dec 31, 2020
@srikanthkb srikanthkb deleted the update-ktlint-version branch January 5, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandwana001 anandwana001 anandwana001 approved these changes

@rt4914 rt4914 rt4914 approved these changes

@FareesHussain FareesHussain FareesHussain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Ktlint version from "0.37.0" to "0.37.1"
4 participants
@srikanthkb @rt4914 @anandwana001 @FareesHussain