-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] added jacoco coverage to oppia-android #2744
Conversation
Please check these comments and let me know if need any help |
0% are the missed instructions and missed branches. Look for what percentage of lines are covered and try to open the particular file then you will see which line is covered and which line is not covered. |
generated a coverage report which shows 80% coverage for app package. |
Jacoco is giving the following results
|
@MaskedCarrot is this code coverage for the Test package or the main codebase? Also, an additional point if you could try out, After generating a report using Jacoco, try to upload them to codecov and check the result. |
@anandwana001 this code coverage is for the main codebase.
What I understand is that we have to create a package |
Closing & reopening to restart now that codecov/codecov-action@v1 has been enabled for actions. |
@BenHenning just to inform you, this is not the main PR. Peculiar is assigned to this issue I am helping her with this. I talked to her about this and we both are facing the same issue(0 coverage in domain). |
With the latest re-run I see |
Thanks for clarifying @MaskedCarrot. Can we maybe close this issue, then, and consolidate on that PR so that there's a single source of truth? |
i also have another pr which I did not open in oppia-android. It ran the action to upload the report to codecov. it has a different task name. I have updated the |
@BenHenning should I close it after the report is uploaded to codecov? Because peculiar has not setup the yml yet. |
closing this issue. further work on this issue will continue in peculiar's PR |
Please I don't understand the issue you are referring here @MaskedCarrot |
@peculiaruc as per our chats on gitter you said that 100 percent of the tests are passing for the domain module but you are getting 0 percent coverage. This is the issue I am referring here |
As I was about getting clearification of your comments. It was a question which I resolved and asked you never mind |
@peculiaruc okay but I think a pr once referenced cannot be removed. |
@peculiaruc can you tell me how did you resolve this issue ? |
Is just to resolved the difference @BenHenning mentioned |
The issue I mentioned here is for ./gradlew :domain:jacocoTestReport. You told @BenHenning you are helping but you keep asking me questions as the reviewers. I think you should be providing solutions not just asking me questions. |
Explanation
Checklist