-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #24: Concept card for review [Blocked on #331] #353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rt4914. Generally LGTM, but please add a test to verify that the html parsing is happening. I believe we can verify this by retrieving the CharSequence from the TextView, casting it to a SpannableString, and then verify there are expected Spans present in the string.
app/src/main/java/org/oppia/app/topic/conceptcard/ConceptCardPresenter.kt
Show resolved
Hide resolved
@jamesxu0 Acknowledge. Will wait for your merge and also some test cases needs change in ID name to fix them, will do that too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
Everything in this PR is done, except for changing the close icon on top-left same as mocks.
Checklist