Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #24: Concept card for review [Blocked on #331] #353

Closed
wants to merge 3 commits into from

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 15, 2019

Explanation

Everything in this PR is done, except for changing the close icon on top-left same as mocks.

Screenshot_1573801557

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914. Generally LGTM, but please add a test to verify that the html parsing is happening. I believe we can verify this by retrieving the CharSequence from the TextView, casting it to a SpannableString, and then verify there are expected Spans present in the string.

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Nov 15, 2019
@jamesxu0
Copy link
Contributor

@rt4914 I would like to merge PR #331 before this one, which creates a recyclerview with the heading, explanation, and worked examples and also test cases with rich text checking.

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 15, 2019

@rt4914 I would like to merge PR #331 before this one, which creates a recyclerview with the heading, explanation, and worked examples and also test cases with rich text checking.

@jamesxu0 Acknowledge. Will wait for your merge and also some test cases needs change in ID name to fix them, will do that too.

@rt4914 rt4914 changed the title Fix part of #24: Concept card for review Fix part of #24: Concept card for review [Blocked on #331] Nov 18, 2019
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veena14cs veena14cs removed their assignment Nov 18, 2019
@jamesxu0
Copy link
Contributor

jamesxu0 commented Nov 19, 2019

@rt4914 PR #331 has been merged into develop. I used a lot of the stylings that were in this PR for concept_card_fragment.xml, so this PR is probably not needed.

@rt4914
Copy link
Contributor Author

rt4914 commented Nov 20, 2019

@rt4914 PR #331 has been merged into develop. I used a lot of the stylings that were in this PR for concept_card_fragment.xml, so this PR is probably not needed.

Thanks a lot @jamesxu0 I will close this PR, and check everything on develop and close the hifi issue accordingly.

@rt4914 rt4914 closed this Nov 20, 2019
@BenHenning BenHenning deleted the concept-card-part-1 branch June 10, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants