Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #143: Review card changes #354

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Fix part of #143: Review card changes #354

merged 2 commits into from
Nov 15, 2019

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 15, 2019 •
edited
Loading

Explanation

This PR fixes review card click and UI, which might get changed later on. This UI is not final and is under discussion within the team, but still it would be good to merge this for now.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the title Fix review card temporarily Fix part of #143: Review card changes Nov 15, 2019
BenHenning
BenHenning approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BenHenning BenHenning assigned rt4914 and unassigned BenHenning Nov 15, 2019
@rt4914 rt4914 merged commit 4e3be63 into develop Nov 15, 2019
@rt4914 rt4914 deleted the fix-nit-issues branch November 15, 2019 17:19
@BenHenning
Copy link
Member

Just to be clear @rt4914, this only appears to fix #364 but not #365, unless I'm missing something.

@BenHenning BenHenning mentioned this pull request Nov 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenHenning BenHenning BenHenning approved these changes

@veena14cs veena14cs Awaiting requested review from veena14cs

@jamesxu0 jamesxu0 Awaiting requested review from jamesxu0

Assignees

@rt4914 rt4914

@veena14cs veena14cs

@jamesxu0 jamesxu0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rt4914 @BenHenning @veena14cs @jamesxu0