Fix #3968: Hi fi tablet create profile reset pin fragment 2 #4011

yash10019coder · 2021-11-23T14:58:30Z

Explanation

Fixes #3968
Introduces ProfileResetPin in its own nested fragment so that it can be used in tablets to utilitize high screen density.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

For admin profile

Old Screenshot	New Screenshot

For non admin profile

Old Screenshot	New Screenshot

Test screenshots for ProfileResetPinActivityTest and ProfileRenamePinFragmentTest

rt4914

@yash10019coder PTAL. The changes suggested are almost similar to other PR.

app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinActivity.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinFragment.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinActivityPresenter.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinFragment.kt

scripts/assets/test_file_exemptions.textproto

…in-fragment-2

…thub.com:yash10019coder/oppia-android into hi-fi-tablet-create-profile-reset-pin-fragment-2

fixed the bug fixes for the failing tests renamed all of the tests.

yash10019coder

Hi @rt4914 completed all the comments PTAL and why are so many files included in this for kdoc_test_exemptions link

…dity_exemptions.textproto.

…module.

yash10019coder

Hi @rt4914 added all the kdocs for the settings.profile package PTAL.

rt4914

Nice work. Suggested nit changes.

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditActivityPresenter.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditDialogInterface.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragment.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditViewModel.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileRenameActivity.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileRenameViewModel.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinActivityPresenter.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinViewModel.kt

scripts/assets/kdoc_validity_exemptions.textproto

BenHenning

Thanks @yash10019coder. Just a few nits left, but otherwise the PR LGTM.

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditViewModel.kt

app/src/main/java/org/oppia/android/app/settings/profile/ProfileResetPinViewModel.kt

…leEditViewModel.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

…leResetPinViewModel.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

yash10019coder

hi @BenHenning mentioned all the comments PTAL thanks

BenHenning

Thanks @yash10019coder. I think you might've missed one detail in my previous comment about making sure that doc comments fill the line; I added a suggested edit to clarify. Once that's resolved, the PR will be ready for review.

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt

…leEditFragmentPresenter.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

yash10019coder

Hi @BenHenning commited the suggested changes PTAL thanks.

yash10019coder · 2021-12-17T05:38:38Z

Thanks @yash10019coder. I think you might've missed one detail in my previous comment about making sure that doc comments fill the line; I added a suggested edit to clarify. Once that's resolved, the PR will be ready for review.

done

BenHenning · 2021-12-17T05:47:23Z

Hi. As of today, some main reviewers have taken time off for the next few weeks, so it may take a little while before we can look at this PR. We appreciate your patience while some of our team members recharge. We'll be fully returning on 4 January 2021.

BenHenning

Thanks @yash10019coder. LGTM for codeowners & doc changes.

oppiabot · 2021-12-17T05:59:19Z

Unassigning @BenHenning since they have already approved the PR.

yash10019coder added 2 commits November 23, 2021 19:42

initial commit

98af06b

added imports in lexicographic order

ae911c3

yash10019coder requested review from BenHenning and rt4914 as code owners November 23, 2021 14:58

yash10019coder assigned rt4914 and BenHenning Nov 23, 2021

rt4914 suggested changes Nov 23, 2021

View reviewed changes

rt4914 assigned yash10019coder and unassigned rt4914 and BenHenning Nov 23, 2021

yash10019coder and others added 9 commits November 25, 2021 11:02

Merge branch 'oppia:develop' into hi-fi-tablet-create-profile-reset-p…

bb43616

…in-fragment-2

nit fixes.

3298bfc

nit fixes.

232647e

removed ProfileResetPinFragment.kt from test_file_exemptions.textproto

7ba6c58

added tests for ProfileResetPinFragmentTest.kt

068b9ad

reformatted the code.

ee588df

Merge branch 'hi-fi-tablet-create-profile-reset-pin-fragment-2' of gi…

8ee26ab

…thub.com:yash10019coder/oppia-android into hi-fi-tablet-create-profile-reset-pin-fragment-2

added ProfileMangagementController in constructor injection

e1acfee

fixed the bug fixes for the failing tests renamed all of the tests.

reformatted the code.

8afd8ee

yash10019coder commented Nov 29, 2021

View reviewed changes

yash10019coder assigned rt4914 and BenHenning and unassigned yash10019coder Nov 29, 2021

yash10019coder requested a review from rt4914 November 29, 2021 06:27

yash10019coder added 3 commits November 29, 2021 21:50

removed unused import.

06a5a05

removed all the files for the settings/profile package from kdoc_vali…

fffd04f

…dity_exemptions.textproto.

added kdocs for all the files in the package settings/profile in app …

570d838

…module.

yash10019coder commented Dec 1, 2021

View reviewed changes

rt4914 suggested changes Dec 1, 2021

View reviewed changes

rt4914 removed their assignment Dec 1, 2021

yash10019coder assigned BenHenning and unassigned yash10019coder Dec 14, 2021

yash10019coder closed this Dec 14, 2021

yash10019coder reopened this Dec 14, 2021

BenHenning reviewed Dec 16, 2021

View reviewed changes

BenHenning assigned yash10019coder and unassigned BenHenning Dec 16, 2021

yash10019coder and others added 7 commits December 16, 2021 15:05

Update app/src/main/java/org/oppia/android/app/settings/profile/Profi…

ba6c152

…leEditViewModel.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

Update app/src/main/java/org/oppia/android/app/settings/profile/Profi…

fb3913b

…leEditViewModel.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

Update app/src/main/java/org/oppia/android/app/settings/profile/Profi…

1085e76

…leEditViewModel.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

Update app/src/main/java/org/oppia/android/app/settings/profile/Profi…

fb6b934

…leEditViewModel.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

Update app/src/main/java/org/oppia/android/app/settings/profile/Profi…

77c57b1

…leResetPinViewModel.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

Update app/src/main/java/org/oppia/android/app/settings/profile/Profi…

4abf615

…leResetPinViewModel.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

reformatted the multiline kdoc.

1bb19c9

yash10019coder commented Dec 16, 2021

View reviewed changes

BenHenning self-assigned this Dec 17, 2021

BenHenning reviewed Dec 17, 2021

View reviewed changes

app/src/main/java/org/oppia/android/app/settings/profile/ProfileEditFragmentPresenter.kt Outdated Show resolved Hide resolved

BenHenning removed their assignment Dec 17, 2021

Update app/src/main/java/org/oppia/android/app/settings/profile/Profi…

426db62

…leEditFragmentPresenter.kt Co-authored-by: Ben Henning <henning.benmax@gmail.com>

yash10019coder assigned BenHenning and unassigned yash10019coder Dec 17, 2021

yash10019coder commented Dec 17, 2021

View reviewed changes

BenHenning approved these changes Dec 17, 2021

View reviewed changes

oppiabot bot unassigned BenHenning Dec 17, 2021

oppiabot bot added the PR: LGTM label Dec 17, 2021

BenHenning merged commit 53e2321 into oppia:develop Dec 17, 2021

yash10019coder mentioned this pull request Jun 14, 2022

Hi-Fi Profile List Tablet #3241

Open

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #3968: Hi fi tablet create profile reset pin fragment 2 #4011

Fix #3968: Hi fi tablet create profile reset pin fragment 2 #4011

yash10019coder commented Nov 23, 2021 •

edited

Loading

rt4914 left a comment

yash10019coder left a comment •

edited

Loading

yash10019coder left a comment

rt4914 left a comment

BenHenning left a comment

yash10019coder left a comment

BenHenning left a comment

yash10019coder left a comment

yash10019coder commented Dec 17, 2021

BenHenning commented Dec 17, 2021

BenHenning left a comment

oppiabot bot commented Dec 17, 2021

Fix #3968: Hi fi tablet create profile reset pin fragment 2 #4011

Fix #3968: Hi fi tablet create profile reset pin fragment 2 #4011

Conversation

yash10019coder commented Nov 23, 2021 • edited Loading

Explanation

Essential Checklist

For UI-specific PRs only

For admin profile

For non admin profile

Test screenshots for ProfileResetPinActivityTest and ProfileRenamePinFragmentTest

rt4914 left a comment

Choose a reason for hiding this comment

yash10019coder left a comment • edited Loading

Choose a reason for hiding this comment

yash10019coder left a comment

Choose a reason for hiding this comment

rt4914 left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

yash10019coder left a comment

Choose a reason for hiding this comment

BenHenning left a comment

Choose a reason for hiding this comment

yash10019coder left a comment

Choose a reason for hiding this comment

yash10019coder commented Dec 17, 2021

BenHenning commented Dec 17, 2021

BenHenning left a comment

Choose a reason for hiding this comment

oppiabot bot commented Dec 17, 2021

yash10019coder commented Nov 23, 2021 •

edited

Loading

yash10019coder left a comment •

edited

Loading