-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3536: Merged home_activity.xml files #4053
Conversation
@rt4910 PTAL |
Hi. As of today, some main reviewers have taken time off for the next few weeks, so it may take a little while before we can look at this PR. We appreciate your patience while some of our team members recharge. We'll be fully returning on 4 January 2021. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukulasija nice the chabges looks good to me.
Assigning @rt4914 for code owner reviews. Thanks! |
Hi @mukulasija, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
@mukulasija do resolve conflicts and update your PR so that it can be merged soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukulasija Thanks. One nit change suggested.
Also please update the title of this PR to:
Fix #3536: Merged home_activity.xml files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
##Merged 3 home_activity xml files into single xml file
Fix #3536
Just deleted 2 of the 3 home_activity files because after comparing in text compare I found that not a single character was different in all three files and also added the layout_height parameter in dimen file.
Following are the before and after screenshots:
Essential Checklist