Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #435: Topic overview icon fixed #439

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Fix #435: Topic overview icon fixed #439

merged 2 commits into from
Nov 20, 2019

Conversation

nikitamarysolomanpvt
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt commented Nov 20, 2019 •
edited
Loading

Explanation

Overview icon fixed

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@nikitamarysolomanpvt nikitamarysolomanpvt merged commit bf5c7a7 into develop Nov 20, 2019
@nikitamarysolomanpvt nikitamarysolomanpvt deleted the topic-overview-icon-fix branch November 20, 2019 07:41
@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Feb 13, 2020
nikitamarysolomanpvt
nikitamarysolomanpvt commented Feb 13, 2020
View reviewed changes
Copy link
Contributor Author

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veena14cs veena14cs veena14cs approved these changes

@rt4914 rt4914 Awaiting requested review from rt4914

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikitamarysolomanpvt @veena14cs @rt4914