-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Part of #4195 : Dark mode implementation - Content and Feedback for Questions and Exploration #4824
Fixes Part of #4195 : Dark mode implementation - Content and Feedback for Questions and Exploration #4824
Conversation
Thanks for submitting this pull request! Some main reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rt4914 PTAL, can you please review this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MohitGupta121 Please generate screenshots for question player too.
Also, link this issue with correct issue number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add android:textColorLink
to all these TextViews
as they might contain some internal hyperlink.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rt4914 PTAL, Done review changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
Explanation
Fixes Part of #4195 : Dark mode implementation - Content and Feedback for Questions and Exploration
Essential Checklist
For UI-specific PRs only
Content and Feedbacks
If your PR includes UI-related changes, then: