Fixes #540: Updates profile admin flow when admin does not have a PIN #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-profile-chooser-fragment
BenHenning
reviewed
Dec 11, 2019
BenHenning
reviewed
Dec 11, 2019
rt4914
reviewed
Dec 11, 2019
There was a problem hiding this comment.
All the test cases in AdminPinActivityTest are failing because of following reason.
After typing, the keyboard is still visible and submit button is behind the keyboard because of which perform(click()) is not working correctly.
Possible solution:
- Scroll to submit button before clicking on it.
- Hide the keyboard before clicking on submit button.
Also, I am seeing that you haven't used fragments in these, but in the entire app we are using fragments for containing everything. This applies to your PRs too. So what is the reason behind this? @jamesxu0 @BenHenning
app/src/main/java/org/oppia/app/profile/ProfileActivityPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/profile/AdminPinActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/profile/ProfileChooserFragmentTest.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/profile/ProfileChooserFragmentTest.kt
Outdated
Show resolved
Hide resolved
|
@BenHenning PTAL. I addressed all of Rajat's comments and fixed the test case. |
jamesxu0
commented
Dec 13, 2019
BenHenning
reviewed
Dec 13, 2019
app/src/main/java/org/oppia/app/profile/ProfileChooserFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
BenHenning
approved these changes
Dec 14, 2019
There was a problem hiding this comment.
Thanks @jamesxu0! Just a few lingering comments to address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #540: Updates profile admin flow when admin does not have a PIN. See https://xd.adobe.com/view/6384f092-e16a-4214-5a1a-f10ee0ef4f04-15b5/screen/18e69208-8528-424a-a368-b2c5d530d235/PC-SP-Profile-Chooser- for new flow. Requires admin to create a new PIN when attempting to add a new profile. Note that the base branch is PR #539.
Checklist