Fix #5344: Remove temporary functions from TopicListController

[theMr17]

Explanation

Fixes #5344

This PR surfaces the getClassrooms and getClassroomById functions from the ClassroomController, adds tests to ensure their correctness, and refactors the TopicListController to replace temporary functions with these new implementations.

Essential Checklist

• The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
• Any changes to scripts/assets files have their rationale included in the PR explanation.
• The PR follows the style guide.
• The PR does not contain any unnecessary code changes from Android Studio (reference).
• The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
• The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

• Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
• For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
• Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
• For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
• Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

[github-actions]

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ClassroomController.kt domain/src/main/java/org/oppia/android/domain/classroom/ClassroomController.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicListController.kt domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

[theMr17]

PTAL @adhiamboperes.

[adhiamboperes]

Thanks @theMr17!

I left a comment inline, but please also cahnge PR title and description to remove "part of" so that this issue can be closed when the PR is merged.

[github-actions]

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ClassroomController.kt domain/src/main/java/org/oppia/android/domain/classroom/ClassroomController.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicListController.kt domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

[github-actions]

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ClassroomController.kt domain/src/main/java/org/oppia/android/domain/classroom/ClassroomController.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicListController.kt domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

[theMr17]

@adhiamboperes PTAL.

[adhiamboperes]

Thanks @theMr17! This LGTM.

[oppiabot]

Assigning @BenHenning for code owner reviews. Thanks!

[github-actions]

Coverage Report

Results

Number of files assessed: 2
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
ClassroomController.kt domain/src/main/java/org/oppia/android/domain/classroom/ClassroomController.kt	This file is incompatible with code coverage tooling; skipping coverage check.
TopicListController.kt domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt	This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page