Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part #646: Low-fi Introduce Subtopic in Practice Mode #649

Merged
merged 20 commits into from
Feb 25, 2020
Merged

Fix part #646: Low-fi Introduce Subtopic in Practice Mode #649

merged 20 commits into from
Feb 25, 2020

Conversation

veena14cs
Copy link
Contributor

@veena14cs veena14cs commented Feb 12, 2020 •
edited
Loading

Explanation

This PR focuses on introducing subtopic in app layer module that is used in Practice Tab.

Design Doc

https://docs.google.com/document/d/1ZH3HWkQeVipkOGQLBTjp6Rjq7z_ac05jHbDXYQq0EN4/edit?usp=sharing

Mock

https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/f403add1-079a-4202-9975-efe04c076290/TP-Train-Unchecked-

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@veena14cs veena14cs changed the base branch from develop to subtopic-domain February 12, 2020 06:19
@veena14cs veena14cs self-assigned this Feb 19, 2020
@veena14cs veena14cs changed the base branch from subtopic-domain to develop February 24, 2020 07:32
rt4914
rt4914 suggested changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit changes suggested.

app/src/main/java/org/oppia/app/topic/practice/SkillSelector.kt Show resolved Hide resolved
app/src/main/java/org/oppia/app/topic/practice/SkillSelector.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/topic/practice/TopicPracticeFragmentPresenter.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/topic/practice/TopicPracticeFragmentPresenter.kt Outdated Show resolved Hide resolved
...in/java/org/oppia/app/topic/practice/practiceitemviewmodel/TopicPracticeSubtopicViewModel.kt Outdated Show resolved Hide resolved
app/src/main/res/layout/topic_practice_skill_view.xml Show resolved Hide resolved
@rt4914 rt4914 removed their assignment Feb 24, 2020
nikitamarysolomanpvt
nikitamarysolomanpvt approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@nikitamarysolomanpvt nikitamarysolomanpvt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please address comments of rajat.

@nikitamarysolomanpvt nikitamarysolomanpvt removed their assignment Feb 24, 2020
@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Feb 24, 2020
rt4914
rt4914 approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Feb 25, 2020
@veena14cs veena14cs merged commit 08235de into develop Feb 25, 2020
@veena14cs veena14cs mentioned this pull request Mar 4, 2020
Closed
@BenHenning BenHenning deleted the subtopic-practice branch June 10, 2020 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitamarysolomanpvt nikitamarysolomanpvt nikitamarysolomanpvt approved these changes

@rt4914 rt4914 rt4914 approved these changes

Assignees

@veena14cs veena14cs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@veena14cs @rt4914 @nikitamarysolomanpvt