Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #690: Refactor Use of Constant Strings #693

Merged

Conversation

PrarabdhGarg
Copy link
Contributor

Fixes #690
The constant string for topic heading was not following the parameterized format, so converted that into the correct format

Explanation

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rt4914
Copy link
Contributor

rt4914 commented Feb 22, 2020

@PrarabdhGarg Please change the title of this PR to Fix #690: ....

@rt4914 rt4914 assigned PrarabdhGarg and unassigned rt4914 Feb 22, 2020
@PrarabdhGarg PrarabdhGarg changed the title Fix 690: Refactor Use of Constant Strings Fix #690: Refactor Use of Constant Strings Feb 22, 2020
@PrarabdhGarg PrarabdhGarg assigned rt4914 and unassigned PrarabdhGarg Feb 22, 2020
@PrarabdhGarg
Copy link
Contributor Author

@rt4914 Done

@rt4914 rt4914 merged commit 1d08866 into oppia:develop Feb 22, 2020
@PrarabdhGarg PrarabdhGarg deleted the fix-690-refactor-use-of-constant-strings branch February 22, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor use of constant strings
2 participants