-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #690: Refactor Use of Constant Strings #693
Merged
rt4914
merged 12 commits into
oppia:develop
from
PrarabdhGarg:fix-690-refactor-use-of-constant-strings
Feb 22, 2020
Merged
Fix #690: Refactor Use of Constant Strings #693
rt4914
merged 12 commits into
oppia:develop
from
PrarabdhGarg:fix-690-refactor-use-of-constant-strings
Feb 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync forked repository
rt4914
approved these changes
Feb 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@PrarabdhGarg Please change the title of this PR to |
PrarabdhGarg
changed the title
Fix 690: Refactor Use of Constant Strings
Fix #690: Refactor Use of Constant Strings
Feb 22, 2020
@rt4914 Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #690
The constant string for topic heading was not following the parameterized format, so converted that into the correct format
Explanation
Checklist