Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #662: Introduced download permissions for device settings in domain layer #725

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Feb 28, 2020

Fix #662 - Lowfi Device Settings

Explanation

Mock Link: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/71345025-f19e-4cac-a63f-e94442540e8f/Settings-6/

This PR is related to the Downloading Permissions inside AdministratorControls.
The permissions will be accessible by any user but can be updated by admin profile only.

Considering that @BenHenning has already given guidance on this and this PR is somewhat straight forward, @veena14cs & @nikitamarysolomanpvt will be the only reviewer of this PR.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor Author

rt4914 commented Feb 28, 2020

@veena14cs actually I missed that you are still reviewing this PR. Will wait for your review to get finished

Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at testcases

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Feb 28, 2020
@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Feb 28, 2020
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rt4914 rt4914 merged commit 8998c15 into develop Feb 28, 2020
@rt4914 rt4914 deleted the domain-device-settings branch February 28, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lowfi Admin Controls (Part 6): Downloading Permissions
3 participants