Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nit changes #740

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Nit changes #740

merged 1 commit into from
Mar 5, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Mar 5, 2020

Explanation

This PR does not contain any issue number and is a part of #700

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor Author

rt4914 commented Mar 5, 2020

@aggarwalpulkit596 This PR has been assigned to you for review considering that you are a regular contributor to Oppia-Android and that means that other than code-contributor it would be nice for you to increase your expertise as code-reviewer too. Thanks. Mainly you need to run the test test cases and see if they are passing.

@aggarwalpulkit596
Copy link
Contributor

LGTM

@rt4914 rt4914 merged commit 63c99f6 into develop Mar 5, 2020
@rt4914 rt4914 deleted the nit-fixes branch March 5, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants