Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix part of #736: Lowfi completed story list #748

Merged
merged 14 commits into from
Mar 16, 2020
Merged

Fix part of #736: Lowfi completed story list #748

merged 14 commits into from
Mar 16, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Mar 6, 2020 •
edited
Loading

Explanation

Mock: https://xd.adobe.com/view/0687f00c-695b-437a-79a6-688e7f4f7552-70b6/screen/f54ae7d1-9530-44d6-8783-21559b13635c/UP-Stories-Completed-

Finished CompletedStoryListActivity implementation.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 changed the base branch from develop to domain-story-summary-thumbnail March 15, 2020 21:27
@rt4914 rt4914 changed the title Fix part of #736: Lowfi completed story list [WIP] Fix part of #736: Lowfi completed story list Mar 15, 2020
@rt4914 rt4914 changed the base branch from domain-story-summary-thumbnail to develop March 16, 2020 05:59
veena14cs
veena14cs suggested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no testcase to check thumbnails?

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Mar 16, 2020
@rt4914 rt4914 assigned veena14cs and unassigned rt4914 Mar 16, 2020
veena14cs
veena14cs approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All testcases are passing.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Mar 16, 2020
@rt4914 rt4914 merged commit e14840e into develop Mar 16, 2020
@rt4914 rt4914 deleted the lowfi-completed-story-list branch March 16, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veena14cs veena14cs veena14cs approved these changes

@nikitamarysolomanpvt nikitamarysolomanpvt Awaiting requested review from nikitamarysolomanpvt

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rt4914 @veena14cs @nikitamarysolomanpvt