Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #809: Introduced StoryThumbnail and updated CompletedStoryList model #810

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Mar 15, 2020

Explanation

Changes

  • Introduced StoryThumbnail in StorySummary and also updates the implementation of PromotedStory by using the StoryThumbnail.
  • Created a new model CompletedStory because we need topicName also in CompletedStoryList
  • Removed some unused models like TopicProgressList and StoryProgressList and therefore code gets updated.

NOTE - This PR has domain and app module code because of we fix only domain layer code then the develop will have crashes.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from veena14cs March 15, 2020 18:42
@rt4914 rt4914 changed the title Fix #809: Introduced StoryThumbnail Fix #809: Introduced StoryThumbnail [WIP] Mar 15, 2020
@rt4914 rt4914 changed the title Fix #809: Introduced StoryThumbnail [WIP] Fix #809: Introduced StoryThumbnail and updated CompletedStoryList model Mar 15, 2020
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Mar 16, 2020
@rt4914 rt4914 merged commit 1df177f into develop Mar 16, 2020
@rt4914 rt4914 deleted the domain-story-summary-thumbnail branch March 16, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants