Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #863: Lowfi Landscape ProfileRenameActivity #864

Merged
merged 5 commits into from
Mar 24, 2020
Merged

Fix #863: Lowfi Landscape ProfileRenameActivity #864

merged 5 commits into from
Mar 24, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Mar 23, 2020

Explanation

Fixes #863

Mock Portrait: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/d0227921-1c24-4bb7-8667-a8fa5f4742dd/AC-EP-Rename-

Mock Landscape: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/screen/b7447549-a7c3-48a9-8ad2-876d0a347708/RG-MN-Register-Empty-36

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from veena14cs March 23, 2020 22:44
@rt4914 rt4914 changed the title Fix #863: Landscape mode ProfileRenameActivity Fix #863: Lowfi Landscape ProfileRenameActivity Mar 23, 2020
veena14cs
veena14cs approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@veena14cs veena14cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside some nit change.

@veena14cs veena14cs assigned rt4914 and unassigned veena14cs Mar 24, 2020
@rt4914 rt4914 merged commit 48a90fc into develop Mar 24, 2020
@rt4914 rt4914 deleted the lowfi-landscape-profile-rename branch March 24, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veena14cs veena14cs veena14cs approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lowfi landscape ProfileRenameActivity
2 participants
@rt4914 @veena14cs